Skip to content

docs: propagate recent fixes to sibling packages#11671

Merged
kgryte merged 2 commits intodevelopfrom
philipp/fix-propagation-2026-04-20
Apr 20, 2026
Merged

docs: propagate recent fixes to sibling packages#11671
kgryte merged 2 commits intodevelopfrom
philipp/fix-propagation-2026-04-20

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented Apr 20, 2026

Propagating fixes merged to develop between 2026-04-19 and 2026-04-20 to sibling packages that carried the same copy-paste defects.

Description

What is the purpose of this pull request?

This pull request:

  • napi/argv-bool — propagates f3dfe11 ("docs: update descriptions"). Commit f3dfe11 swept 33 napi/argv-* README files to correct a copy-paste error in the **err** parameter description, replacing the wrong validated type ("a number") with the correct one for each package. For napi/argv-bool, which validates a JavaScript boolean and stores into bool *out, the phrase now correctly reads "a boolean" in lib/node_modules/@stdlib/napi/argv-bool/README.md (line 140).

  • ndarray/base/rot{l,r}90 — propagates f756fa1 + c2c401e ("docs: update note"). Commits f756fa1 (README) and c2c401e (repl.txt) fixed a missing article in ndarray/rotr90, changing "perform rotation" to "perform a rotation". The same defect was present in the base package siblings; this propagation applies the identical one-word fix to lib/node_modules/@stdlib/ndarray/base/rotl90/README.md and lib/node_modules/@stdlib/ndarray/base/rotr90/README.md (both at line 77).

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. Candidate sites were found by searching the full repository for the defect signatures in scope:

  • Pattern search scope: lib/node_modules/@stdlib/**/benchmark/benchmark.size.{float32,float64}.js for 869c9da (swapped dtypes — 0 sites beyond those already fixed); lib/node_modules/@stdlib/blas/**/benchmark/*.js for cd1a4d3 (wrong b.fail message — see exclusions); lib/node_modules/@stdlib/napi/argv-*/README.md for f3dfe11; rg "perform rotation" repo-wide for f756fa1/c2c401e.
  • Two independent validation agents read each candidate file in full; an adaptation agent produced the per-site wording for the adaptive f3dfe11 fix; a style-consistency pass confirmed spacing and primitive-vs-typed-array wording conventions matched the source commits.

Deliberately excluded. The cd1a4d3 pattern ('should not return NaN''should return an ndarray') surfaced 24 candidate benchmark files across blas/{s,d}{dot,swap}, blas/tools/swap-factory, and blas/ext/*. Every one was rejected: the remaining b.fail( 'should not return NaN' ); calls in those files guard genuine scalar isnan(...) checks (the ndarray-type guards in those same files already use the correct 'should return an ndarray' message). The 869c9da pattern had no propagation sites — sibling benchmark.size.float{32,64}.js files pass dtype as a positional argument rather than an options-object literal, so the filename/dtype mismatch does not occur. No needs-human sites remained after filtering.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code running a fix-propagation routine over the last 24 hours of develop. Candidate source commits were classified into patterns; sibling sites were enumerated with rg, then independently validated (two validation agents), adapted, and style-checked before any patch was applied. Only sites confirmed by both validation passes and the style agent are included.


@stdlib-js/reviewers

claude added 2 commits April 20, 2026 13:42
Propagates fix from f3dfe11 ("docs: update descriptions") to a
sibling napi/argv-* package missed in the original pass. The `**err**`
entry carried a copy-paste "If not provided a number," phrasing; the
helper validates a JS boolean, so the phrase now matches the validated
type.
Propagates fix from f756fa1bee ("docs: update note") and c2c401e
("docs: update note") to the `ndarray/base/rotl90` and
`ndarray/base/rotr90` READMEs. Both mirrored the original "perform
rotation" phrasing from `ndarray/rotr90`; insert the missing article so
the notes now read "perform a rotation".
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
napi/argv-bool $\color{green}146/146$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}146/146$
$\color{green}+100.00%$
ndarray/base/rotl90 $\color{green}96/96$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}96/96$
$\color{green}+100.00%$
ndarray/base/rotr90 $\color{green}152/152$
$\color{green}+100.00%$
$\color{green}10/10$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}152/152$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter marked this pull request as ready for review April 20, 2026 13:51
@Planeshifter Planeshifter requested a review from a team April 20, 2026 13:51
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. labels Apr 20, 2026
@Planeshifter Planeshifter requested a review from kgryte April 20, 2026 13:52
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 20, 2026
@kgryte kgryte merged commit 59d0640 into develop Apr 20, 2026
58 checks passed
@kgryte kgryte deleted the philipp/fix-propagation-2026-04-20 branch April 20, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants