docs: propagate recent fixes to sibling packages#11671
Merged
Conversation
Propagates fix from f3dfe11 ("docs: update descriptions") to a sibling napi/argv-* package missed in the original pass. The `**err**` entry carried a copy-paste "If not provided a number," phrasing; the helper validates a JS boolean, so the phrase now matches the validated type.
Propagates fix from f756fa1bee ("docs: update note") and c2c401e
("docs: update note") to the `ndarray/base/rotl90` and
`ndarray/base/rotr90` READMEs. Both mirrored the original "perform
rotation" phrasing from `ndarray/rotr90`; insert the missing article so
the notes now read "perform a rotation".
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagating fixes merged to
developbetween 2026-04-19 and 2026-04-20 to sibling packages that carried the same copy-paste defects.Description
This pull request:
napi/argv-bool— propagatesf3dfe11("docs: update descriptions"). Commitf3dfe11swept 33napi/argv-*README files to correct a copy-paste error in the**err**parameter description, replacing the wrong validated type ("a number") with the correct one for each package. Fornapi/argv-bool, which validates a JavaScriptbooleanand stores intobool *out, the phrase now correctly reads "a boolean" inlib/node_modules/@stdlib/napi/argv-bool/README.md(line 140).ndarray/base/rot{l,r}90— propagatesf756fa1+c2c401e("docs: update note"). Commitsf756fa1(README) andc2c401e(repl.txt) fixed a missing article inndarray/rotr90, changing "perform rotation" to "perform a rotation". The same defect was present in the base package siblings; this propagation applies the identical one-word fix tolib/node_modules/@stdlib/ndarray/base/rotl90/README.mdandlib/node_modules/@stdlib/ndarray/base/rotr90/README.md(both at line 77).Related Issues
No.
Questions
No.
Other
Validation. Candidate sites were found by searching the full repository for the defect signatures in scope:
lib/node_modules/@stdlib/**/benchmark/benchmark.size.{float32,float64}.jsfor869c9da(swapped dtypes — 0 sites beyond those already fixed);lib/node_modules/@stdlib/blas/**/benchmark/*.jsforcd1a4d3(wrongb.failmessage — see exclusions);lib/node_modules/@stdlib/napi/argv-*/README.mdforf3dfe11;rg "perform rotation"repo-wide forf756fa1/c2c401e.f3dfe11fix; a style-consistency pass confirmed spacing and primitive-vs-typed-array wording conventions matched the source commits.Deliberately excluded. The
cd1a4d3pattern ('should not return NaN'→'should return an ndarray') surfaced 24 candidate benchmark files acrossblas/{s,d}{dot,swap},blas/tools/swap-factory, andblas/ext/*. Every one was rejected: the remainingb.fail( 'should not return NaN' );calls in those files guard genuine scalarisnan(...)checks (the ndarray-type guards in those same files already use the correct'should return an ndarray'message). The869c9dapattern had no propagation sites — siblingbenchmark.size.float{32,64}.jsfiles passdtypeas a positional argument rather than an options-object literal, so the filename/dtype mismatch does not occur. Noneeds-humansites remained after filtering.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running a fix-propagation routine over the last 24 hours of
develop. Candidate source commits were classified into patterns; sibling sites were enumerated withrg, then independently validated (two validation agents), adapted, and style-checked before any patch was applied. Only sites confirmed by both validation passes and the style agent are included.@stdlib-js/reviewers